It being for sale means anyone can be doing it which might be a framing that would be more alarming to the law-and-order types.
But really you need a two prong solution:
1) restrict this from being collected and compiled in the first place, eliminate the ability to default to this tracking unless someone opts out
2) restrict the government's ability to use or acquire through non-market-based means. The claim here is that there's already restrictions on this vs directly surveiling, but I haven't seen directly which specific restrictions those are for buying off-the-shelf info and the article doesn't specify.
There are very really no companies that I trust to keep my data safe for 10, 20, 50 years. Leadership changes, ownership changes, etc. We have to cut it off at the source.
If you rent a locker, and the terms of the rental agreement say that the person you're renting from has access to the locker for any reason, then the cops do not need a warrant to ask the lessor to open the locker, only a warrant to coerce the lessor to open the locker.
If the lessor is willing to let anybody take a picture of what is in the locker for $5, then the government doing so isn't abusing its special privilege.
In practice, most people do not understand the ramifications of the things they agreed to that put this data out there (if they even read it!) and in many cases did not have reasonable alternatives to the services that they signed up for.