zlacker

[parent] [thread] 3 comments
1. colinm+(OP)[view] [source] 2026-02-08 20:02:26
Sounds like you misunderstood. They didn't say they are merging PRs after a few seconds. Just that the difference between a good one and a bad is often obvious after a few seconds. Edit: typos
replies(2): >>adeebs+h9 >>stavro+wa
2. adeebs+h9[view] [source] 2026-02-08 21:08:13
>>colinm+(OP)
Exactly, every PR starts with:

1. What’s the goal of this PR and how does it further our project’s goals?

2. Is this vaguely the correct implementation?

Evaluating those two takes a few seconds. Beyond that, yes it takes a while to review and merge even a few line diff.

3. stavro+wa[view] [source] 2026-02-08 21:17:40
>>colinm+(OP)
I'm not sure there are many ways to interpret "I know whether I want to merge a PR within a few seconds".
replies(1): >>jeremy+Be
◧◩
4. jeremy+Be[view] [source] [discussion] 2026-02-08 21:48:33
>>stavro+wa
Yet I also agree with GP.
[go to top]