zlacker

[parent] [thread] 1 comments
1. tyre+(OP)[view] [source] 2026-01-17 04:22:12
Eight hours to review! Girlie how big are these PRs?

I can’t imagine saying, “ah, only six hours of heads down time to review this. That’s reasonable.”

A combination of peer reviewed architecture documentation and incremental PRs should prevent anything taking nearly 8 hours of review.

replies(1): >>embedd+QJ
2. embedd+QJ[view] [source] 2026-01-17 13:49:23
>>tyre+(OP)
Agreed, if it takes 8 hours to review a PR, then the process is broken and you need to start talking before anyone starts writing code. I'd put the max window on maybe 30 minutes for a PR, otherwise we're doing something else, not a "last pass before merge into production".
[go to top]