zlacker

[return to "Vouch"]
1. adeebs+1C1[view] [source] 2026-02-08 18:41:03
>>chwtut+(OP)
"Open source has always worked on a system of trust and verify"

Not sure about the trust part. Ideally, you can evaluate the change on its own.

In my experience, I immediately know whether I want to close or merge a PR within a few seconds, and the hard part is writing the response to close it such that they don't come back again with the same stuff.

(I review a lot of PRs for openpilot - https://github.com/commaai/openpilot)

◧◩
2. rafram+CD1[view] [source] 2026-02-08 18:50:58
>>adeebs+1C1
[flagged]
◧◩◪
3. BowBun+EH1[view] [source] 2026-02-08 19:18:08
>>rafram+CD1
Why? I don't appreciate comments that cast doubt on decent technical contributors without any substance to back it up. It's a cheap shot from anonymity.
◧◩◪◨
4. 8n4vid+yK1[view] [source] 2026-02-08 19:35:24
>>BowBun+EH1
I'm not the parent but if you know you want to merge a PR "within a few seconds" then you're likely to be merging in bad changes.

If you had left it at know you want to reject a PR within a few seconds, that'd be fine.

Although with safety critical systems I'd probably want each contributor to have some experience in the field too.

◧◩◪◨⬒
5. colinm+MO1[view] [source] 2026-02-08 20:02:26
>>8n4vid+yK1
Sounds like you misunderstood. They didn't say they are merging PRs after a few seconds. Just that the difference between a good one and a bad is often obvious after a few seconds. Edit: typos
◧◩◪◨⬒⬓
6. stavro+iZ1[view] [source] 2026-02-08 21:17:40
>>colinm+MO1
I'm not sure there are many ways to interpret "I know whether I want to merge a PR within a few seconds".
[go to top]