The only drawback is that the battery life has gotten worse since I originally bought it. But if I could easily swap that out, I would keep it for another five years.
EDIT: Oh, and the fingerprint scanner on the power button seems to work way more reliably, IMO, than the embedded fingerprint scanners under the touchscreens.
I'm not saying it's trivial (it's not hard, but has a large enough amount of small actions to execute), but it's definitely worth doubling (or more) the phone duration.
The FamousProducer™ of my phone supported it for 3 years. This is terrible. LineageOS allows me to use it now - over 3 years after the end of support. Screw FamousProducer™.
Why be so coy about this? Naming and shaming should serve as a warning to those who might buy one expecting long term support, or as a spur to action towards LineageOS for those who many have been or are about to be blindsided by the support window expiring.