zlacker

I think I like the idea, but the structure of the code doesn't look the best. What most sticks out to me is the "Managers" directory. I've seen similar patterns before, even at my current place of work, but they seem to correlate with less experienced implementations. For instance, I clicked on one of them randomly and already found an issue: https://github.com/nook-browser/Nook/blob/09a4c6957a2e9fd7c5...

I guess `www.` (and only `www.`) is always special, and the only TLDs with two components are `"co.uk", "co.jp", "com.au", "co.nz", "com.br"`?

I don't know how critical this "Manager" is (what even is a "boost"?), but a web browser should absolutely have a proper list of TLDs!

>>LoganD+(OP)
> the only TLDs with two components are `"co.uk", "co.jp", "com.au", "co.nz", "com.br".

Is this sarcasm? The public suffix list will give some ideas for omissions: https://publicsuffix.org/list/public_suffix_list.dat

>>normie+G5
That was me pointing out what was plainly implemented in the code snippet I linked. It is obviously nowhere near the truth.

>>normie+G5
Right; top-level comment is saying that those are all missing from the linked code.

>>LoganD+(OP)
Uh oh. Looks bad.

>>LoganD+(OP)
> What most sticks out to me is the "Managers" directory. I've seen similar patterns before, even at my current place of work, but they seem to correlate with less experienced implementations

What is wrong with such structure? How would you structure this code? Genuinely asking